Repository navigation
Conversation
A recovery backup saved before the did:ad: to atomic: rename names the agent as did:ad:agent:..., and a secret exported before it still decodes to that spelling, while a newer one decodes to atomic:agent:.... The reconcile gate and the secret sign-in compared the strings, so one agent looked like two: opening the app while signed in to atomic.place archived the local identity and sent the user to sign in, and signing in with the secret then ended the account session, which signs out of atomic.place too because the session cookie is shared. #1664 fixed the same comparison inside recovery.ts. Export its sameAgent and use it in reconcile.ts, the secret sign-in's conflicting-session check, and the two places that match the cached backup to the agent.
joepio
added a commit
that referenced
this pull request
Sep 25, 2026
# Conflicts: # browser/CHANGELOG.md
joepio
added a commit
that referenced
this pull request
Sep 25, 2026
Member
Author
|
Landed on develop in ef161c3 via the combined batch #1844 (green on Mancave, run 4645). Closing. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: someone signed in to atomic.place whose recovery backup was saved before the
did:ad:→atomic:rename (or whose secret was exported before it) opened the app and was sent to sign in again, because the reconcile gate thought the agent on the device was a different one from the account's. Signing in with their secret then ended the account session ("that secret belongs to a different one"), which also signs them out of atomic.place, since the portal and the app share the session cookie.After:
did:ad:agent:Xandatomic:agent:Xcount as the same agent everywhere the app checks the device's agent against the account. The gate leaves the user in the app, and the secret sign-in only ends the account session when the secret really is another agent's.How: #1664 already fixed this comparison inside
recovery.tswith asameAgenthelper built oncanonicalIdentifier. It is now exported and used inreconcile.ts(backup, enrollment and binding checks), inreleaseConflictingPortalSessioninGettingStartedFlow.tsx, and in the two places that match the cached backup to the agent (AccountRecoveryCard.tsx,SyncRoute.tsx). New tests inreconcile.test.tscover both spellings and a genuinely different agent. The two spelling tests fail without the change.Related Issues
Reported sign-out on atomic.place after entering the secret in the app (25 Sep).
Checklist
Generated by Claude Code